[SPARK-59455][PYTHON] Move Arrow-to-pandas batch conversion into ArrowToPandasConversion - #58754
Closed
Spenserrrr wants to merge 1 commit into
Closed
Spenserrrr wants to merge 1 commit into
Spenserrrr wants to merge 1 commit into
Conversation
…wToPandasConversion
Spenserrrr
changed the title
Spenserrrr
marked this pull request as ready for review
September 13, 2026 07:45
Contributor
Author
|
Hi @Yicong-Huang @zhengruifeng! This PR moves to_pandas into ArrowToPandasConversion, following the discussion in #53963. Could you take a look when you have time? Thanks! |
Yicong-Huang
approved these changes
Sep 14, 2026
Yicong-Huang
left a comment
Yicong-Huang
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for helping moving the method!
uros-b
approved these changes
Sep 14, 2026
Member
|
Thank you @Spenserrrr and @Yicong-Huang! |
gaogaotiantian
approved these changes
Sep 14, 2026
Yicong-Huang
pushed a commit
that referenced
this pull request
Sep 14, 2026
…wToPandasConversion ### What changes were proposed in this pull request? Rename `ArrowArrayToPandasConversion` to `ArrowToPandasConversion` and move `ArrowBatchTransformer.to_pandas` into it, updating callers, tests, and benchmarks. ### Why are the changes needed? [#53963](#53963) has a [review discussion](#53963 (comment)) about moving `to_pandas` into `ArrowToPandasConversion`. This groups batch and column conversion in the directional converter and keeps `ArrowBatchTransformer` focused on Arrow-to-Arrow operations. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing conversion tests and baseline-versus-refactor parity probes under pandas 2 and 3, plus benchmark smoke checks. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Codex (GPT-6) Closes #58754 from Spenserrrr/arrow-to-pandas-refactor. Authored-by: Spenser Sun <hsun112358@gmail.com> Signed-off-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com> (cherry picked from commit 3033357) Signed-off-by: Yicong-Huang <17627829+Yicong-Huang@users.noreply.github.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename
ArrowArrayToPandasConversiontoArrowToPandasConversionand moveArrowBatchTransformer.to_pandasinto it, updating callers, tests, and benchmarks.Why are the changes needed?
#53963 has a review discussion about moving
to_pandasintoArrowToPandasConversion. This groups batch and column conversion in the directional converter and keepsArrowBatchTransformerfocused on Arrow-to-Arrow operations.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing conversion tests and baseline-versus-refactor parity probes under pandas 2 and 3, plus benchmark smoke checks.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-6)